[4.2 EARLY] Just autolink everything #16391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
May 4, 2018
jrose-apple
commented
- Explanation: If module A uses some inlinable code from module B (including function default arguments), and that code uses a symbol in module C, but module A doesn't itself import module C, we'll get a link error. This change conservatively autolinks any modules that are transitively imported, even if they aren't re-exported by their intervening modules.
- Scope: As described in the explanation. We've seen this on at least one Apple-internal project.
- Issue: rdar://problem/39338239
- Risk: Medium-low. There's basically no way that this could result in fewer things being linked, so the main risk is whether more things will get linked than before, or if this drastically slows down compilation or linking. That seems unlikely (and hasn't been observed).
- Testing: Added compiler regression tests.
- Reviewed by: @graydon and @DougGregor
And disable them on non-ObjC platforms again, because those overlays depend on a stdlib that contains _ObjectiveCBridgeable. (cherry picked from commit 0e5100d)
This is unfortunate in that it makes the linker do extra work, but in practice it probably doesn't matter much, and meanwhile it handles all our problems with @inlinable. Alternate solution to rdar://problem/39338239 (cherry picked from commit 098b170)
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.