[CMake] Add explicit Glibc dependencies to account for "autolinking" #16401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76ef276 made the compiler autolink libraries more eagerly than before. This normally wouldn't affect the products we build with CMake, but when an overlay is autolinked the compiler also puts in a dummy symbol to make sure it gets linked. So now we have to link to the overlay directly.
|
@davezarzycki, does this fix your build failure? @swift-ci Please clean test Linux |
|
This appears to fix it. Thanks for the quick turnaround! |
davezarzycki
approved these changes
May 4, 2018
|
@swift-ci Please smoke test macOS |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 5, 2018
…wiftlang#16401) 76ef276 made the compiler autolink libraries more eagerly than before. This normally wouldn't affect the products we build with CMake, but when an overlay is autolinked the compiler also puts in a dummy symbol to make sure it gets linked. So now we have to link to the overlay directly. (cherry picked from commit 2b31ba3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16349 made the compiler autolink libraries more eagerly than before. This normally wouldn't affect the products we build with CMake, but when an overlay is autolinked the compiler also puts in a dummy symbol to make sure it gets linked. So now we have to link to the overlay directly.
rdar://problem/39338239