Skip to content

[4.2] [CMake] Add explicit Glibc dependencies to account for "autolinking" #16409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jrose-apple
Copy link
Contributor

Cherry-pick of #16401 to the 4.2 branch. Reviewed by @davezarzycki.

…wiftlang#16401)

76ef276 made the compiler autolink libraries more eagerly than before.
This normally wouldn't affect the products we build with CMake, but
when an overlay is autolinked the compiler also puts in a dummy symbol
to make sure it gets linked. So now we have to link to the overlay
directly.

(cherry picked from commit 2b31ba3)
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test and merge

@swift-ci swift-ci merged commit 691c708 into swiftlang:swift-4.2-branch May 5, 2018
@jrose-apple jrose-apple deleted the 4.2-the-force-is-strong-with-this-one branch May 7, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants