[pred-memopt] Replace remaining occurances of prefix DI with PMO prefix. #16774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am going to DI and predictable mem opts have been split for a long time and their subroutines aren't going to be joined in the future... so replace the DI prefixes in pred-mem-opts impl with PMO and rename DIMemoryUseCollector => PMOUseCollector. Been sitting on this for a long time... just happy to get it in.
|
@swift-ci smoke test |
atrick
approved these changes
May 23, 2018
| @@ -11,22 +11,22 @@ | |||
| //===----------------------------------------------------------------------===// | |||
There was a problem hiding this comment.
How about a file comment explaining what PMO means, and how this differs from DIMemoryUseCollectorOwnership. Are you going to rename DIMemoryUseCollectorOwnership to DIMemoryUseCollector now? Otherwise, it looks like this is all reformatting. Seems fine to me.
There was a problem hiding this comment.
Yes. I can add a comment calling out that this PMO means Predictable Memory Operations. The main thing I am trying to do is finish that transition so I am going to rename do DIMemoryUseCollector.
There was a problem hiding this comment.
I am going to do that in a follow up commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going to DI and predictable mem opts have been split for a long time and
their subroutines aren't going to be joined in the future... so replace the DI
prefixes in pred-mem-opts impl with PMO and rename DIMemoryUseCollector =>
PMOUseCollector.
Been sitting on this for a long time... just happy to get it in.
@atrick this is a pretty straight forward conversion. Can you take a look and make sure I didn't miss anything? I think eventually we will want to re-unify some parts of the implementations (for instance I think we could unify DIMemoryInfo and PMOMemoryInfo).
I ran into this in my local git repo while looking at some other stuff... I just wanted to get it into GitHub. So there isn't a rush with this, but can you take a look sooner rather than later?