[pred-memopts] Add a large file comment to PMOMemoryUtils.h explainin… #16871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the history of the utilities and that the code in DIMemoryUtils is similar due to this historical relationship.
|
@swift-ci smoke test and merge |
atrick
reviewed
May 29, 2018
| /// of the SIL ownership model to SIL was used as an opportunity to split the | ||
| /// two, flatten the sphagetti conditional code so the logic was clear, and | ||
| /// allow the two passes to diverge and hew their form closer to their function. | ||
| /// |
There was a problem hiding this comment.
Thanks. There are a couple of typos here: similra, sphagetti. But if you do another round I suggest stripping out the unnecessary commentary. It's good to note why this file is separate from DIMemoryUseCollector now, but no one needs to backstory. In particular, there's no need to pass judgement on previous versions of the code. That stuff belongs in the commit log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g the history of the utilities and that the code in DIMemoryUtils is similar due to this historical relationship.