[Runtime] Fix double-frees in ConcurrentReadableArray. #16794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apshots rather than using a callback-based read call. rdar://problem/40230581
…ouble-free items. Also implement a destructor so it can be used for non-globals. rdar://problem/40484362
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sort of forgot to clear out
FreeListafter destroying all the stuff inside it. The result is that the second time through, the same storage blocks would be destroyed again, resulting in a crash or worse.This clears
FreeListafter destroying the stuff inside. It also adds a destructor so the thing doesn't leak when used as a non-global, and a basic test to verify that adding a non-trivial number of elements actually works.Thanks to @gwynne for finding this.
rdar://problem/40484362