[Runtime] 4.2 - Change protocol conformance scanning to use a concurrent array rather than a locked vector. #16799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ray rather than a locked vector. rdar://problem/37173156
…k for malloc failure. Use placement new when appending values. rdar://problem/37173156
…rentReadableArray. Remove a redundant load of Count. Fix memory ordering on ReaderCount. rdar://problem/37173156
…s into Storage. Mark ConcurrentReadableArray as un-copyable, un-assignable, and un-movable. Use SWIFT_MEMORY_ORDER_CONSUME instead of std::memory_order_consume. Make read() pass a const pointer. rdar://problem/37173156
…apshots rather than using a callback-based read call. rdar://problem/40230581
…ouble-free items. Also implement a destructor so it can be used for non-globals. rdar://problem/40484362
|
@swift-ci please test |
|
Looks like you broke Linux builds with this (something not including std::vector, at the very least). Not sure how the tests would have passed—maybe a 16.04 vs. 16.10 difference? |
|
Yeah, I don't get it either. #16814 fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks #16254 and #16794 (which fixes #16254) into 4.2.
This eliminates the "gross" unlock/lock dance around
getWitnessTable.rdar://problem/37173156 and rdar://problem/40484362