[definite-init] Treat destroys of mark_uninitialized [var] container to be a load + destroy. #16844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcci
reviewed
May 25, 2018
| SILBasicBlock::iterator InsertPt) { | ||
| assert(ABI == Release->getOperand(0)); | ||
| SILBuilderWithScope B(Release); | ||
| B.setInsertionPoint(InsertPt); |
There was a problem hiding this comment.
Here you're updating the insertion point but not the debug scope. Is this intentional?
There was a problem hiding this comment.
I just followed the model in other parts of the file. If this is wrong then the other places are wrong as well.
|
I am going to get rid of the dead code commits in another PR to make this easier to review. |
gottesmm
force-pushed
the
definite-init-fix
branch
from
9458cad to
dfb8e89
Compare
|
@swift-ci smoke test |
gottesmm
force-pushed
the
definite-init-fix
branch
2 times, most recently
from
b634507 to
6708e99
Compare
|
@swift-ci smoke test and merge |
4 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
gottesmm
force-pushed
the
definite-init-fix
branch
from
6708e99 to
4f83e63
Compare
|
I put in a special case for the lldb failures... = /. |
|
@swift-ci smoke test and merge |
…to be a load + destroy. This ensures that DI creates dealloc_box in cases where the box is uninitialized conditionally. In the process, I also discovered that we were missing a test case for DI being used by LLDB. Long term we shouldn't support that code pattern in the general case, but for now we at least need a test case for it. rdar://40332620
gottesmm
force-pushed
the
definite-init-fix
branch
from
4f83e63 to
8886368
Compare
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that DI creates dealloc_box in cases where the box is uninitialized
conditionally, i.e.:
func foo() {
var k: Klass
if condition() { return } // <== We need to use a dealloc_box on k.
k = Klass()
}
rdar://40332620
I also deleted some dead code, so please look at just the last commit. I am going to squash at the end.