Delete Dead Code from DI #16849
Merged
Delete Dead Code from DI #16849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I test by moving raw sil lowering tests => raw_sil_inst_lowering.sil. rdar://i0332620
collectRetainCountInfo bails early if our memory instruction is a mark_uninitialized... but our instruction is always a mark_uninitialized... so this code is dead. The origin of this code is from the flattening of the control flow in DI that was necessary to be done to "extract" predictable mem opts from it. rdar://40332620
…ore dead code and conditional checks. rdar://40332620
|
This is the dead code removal moved out of #16844. |
|
@swift-ci smoke test and merge |
slavapestov
reviewed
May 25, 2018
| } | ||
|
|
||
| auto *MUI = cast<MarkUninitializedInst>(MemoryInst); | ||
| auto *MUI = MemoryInst; |
There was a problem hiding this comment.
Remove MUI since you never re-assign it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just deleting dead code. DefiniteInitialization has the property that MemoryInst is always a MarkUninitializedInst. So anything that will never run if MemoryInst is a MarkUninitializedInst is trivially dead.