[Type checker] Use the request-evaluator in the type checker. #16963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
force-pushed
the
evaluator-type-checker
branch
from
488aa56 to
b3aa596
Compare
DougGregor
force-pushed
the
evaluator-type-checker
branch
from
0af486c to
5104a6f
Compare
DougGregor
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
DougGregor
force-pushed
the
evaluator-type-checker
branch
from
5104a6f to
ab76edd
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
Wire up the request-evaluator with an instance in ASTContext, and introduce two request kinds: one to retrieve the superclass of a class declaration, and one to compute the type of an entry in the inheritance clause. Teach ClassDecl::getSuperclass() to go through the request-evaluator, centralizing the logic to compute and extract the superclass type. Fixes the crasher from rdar://problem/26498438.
TypeLocs have been “validated” when they have a non-null Type, so eliminate the separate “validated” bit that was out-of-sync with the Type field.
Similar to get “superclass of class” request, introduce an “enum raw type” request that is accessed via EnumDecl::getRawType().
…liases. The ITC is providing no benefit here; stop using it.
We were suppressing diagnostics for some request kinds; we shouldn't do that.
…hecker. The type checker has *lots* cycles, and producing diagnostics for them at this point in the development of the request-evaluator is not productive because it breaks currently-working code. Disable cycle diagnostics for now when using the request-evaluator in the type checker. We'll enable it later as things improve, or as a separate logging mode in the interim.
Implement TypeChecker::resolveInheritedProtocols() in terms of "getInheritedType()" queries, instead. [Sema] Put back resolveInheritedProtocols(). We're still depending on it to update state in some cases.
…ecls. Addresses a regression introduced by the request-evaluator in multi-file projects, where some extensions wouldn't get realized until they are needed in IR generation.
DougGregor
force-pushed
the
evaluator-type-checker
branch
from
94021eb to
fc7b3c9
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
…nce. The introduction of the request-evaluator is causing some conformances to be formed before the nominal type's signature is being checked, causing a crash while type-checking the standard library. Ensure that this cannot happen.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
Tests on Linux run cleanly with that last commit. I'm getting excited |
|
The Linux failure is only the (known) llbuild issue from swiftlang/swift-llbuild#328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.