Skip to content

[Sema] Remove iterative type checker #17199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Jun 14, 2018

While an interesting design, the iterative type checker didn't pan out. It was replaced by the request-evaluator design (partially) adopted by the type checker in #16963.

@slavapestov
Copy link
Contributor

Can you keep the document around? It's still interesting because it does a good job of explaining the problems with the current design.

@DougGregor DougGregor force-pushed the remove-iterative-type-checker branch from d36255f to 1e91aac Compare June 16, 2018 05:44
@DougGregor
Copy link
Member Author

Hmm... we can keep the document around. I guess I could update it for the request-evaluator. It affects my negative line count, though :)

@DougGregor DougGregor force-pushed the remove-iterative-type-checker branch from 1e91aac to d098b3e Compare June 16, 2018 05:47
@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

3 similar comments
@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 27b4501 into swiftlang:master Jun 16, 2018
@DougGregor DougGregor deleted the remove-iterative-type-checker branch June 16, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants