CastOptimizer: A load store to the existential box is not valid on ad… #17113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dress only types rdar://40949457
|
@swift-ci Please test and merge |
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
|
@aschwaighofer I don't see anything in the code that communicates this invariant. For example, I at least want to see a comment in the unit test explaining why a copy_addr needs to be emitted. Maybe a comment in the code explaining the same. Can SILVerifier catch this? |
|
@atrick The invariant is that you can't load address-only types. That is a pretty fundamental property in SIL. At least for now. This is not enforced by the SIL verifier apparently (because I think this was tripping up in IRGen in a non-assert build). It will trip an assert in an asserts build. I forgot whether it was the SILBuilder or the the LoadInst constructor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dress only types
rdar://40949457