Skip to content

CastOptimizer: A load store to the existential box is not valid on ad… #17113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2018
Merged

CastOptimizer: A load store to the existential box is not valid on ad… #17113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8b5f1c
CastOptimizer: A load store to the existential box is not valid on ad…
aschwaighofer Jun 11, 2018
7b7189f
Fix test case
aschwaighofer Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/SILOptimizer/Utils/CastOptimizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,10 +1434,7 @@ static bool optimizeStaticallyKnownProtocolConformance(
SourceType, Conformances);
auto Projection =
B.createProjectExistentialBox(Loc, Src->getType(), AllocBox);
auto Value = B.createLoad(Loc, Src,
swift::LoadOwnershipQualifier::Unqualified);
B.createStore(Loc, Value, Projection,
swift::StoreOwnershipQualifier::Unqualified);
B.createCopyAddr(Loc, Src, Projection, IsTake, IsInitialization);
B.createStore(Loc, AllocBox, Dest,
swift::StoreOwnershipQualifier::Unqualified);
break;
Expand Down
3 changes: 1 addition & 2 deletions test/SILOptimizer/constant_propagation.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,8 +889,7 @@ bb0(%0 : $*MyError, %1 : $*E2<X>):
// CHECK-NOT: unconditional_checked_cast_addr
// CHECK: [[ALLOC_BOX:%.*]] = alloc_existential_box $Error, $E1
// CHECK: [[PROJ:%.*]] = project_existential_box $E1 in [[ALLOC_BOX]] : $Error
// CHECK: [[VAL:%.*]] = load %1 : $*E1
// CHECK: store [[VAL]] to [[PROJ]]
// CHECK: copy_addr [take] %1 to [initialization] [[PROJ]]
// CHECK: store [[ALLOC_BOX]] to %0 : $*Error
// CHECK: return
sil @replace_unconditional_check_cast_addr_for_type_to_error_existential : $@convention(thin) (@in E1) -> (@out Error) {
Expand Down
25 changes: 25 additions & 0 deletions test/SILOptimizer/sil_combine_objc_bridge.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,3 +197,28 @@ bb0(%0 : $*NSObject, %1 : $*Array<String>):
return %7 : $()
}

enum AddressOnlyError : Error {
case data(Data)
case none
}

// CHECK-LABEL: sil @unconditional_checked_cast_addr_address_only_type
// CHECK: alloc_stack $Error
// CHECK: alloc_stack $AddressOnlyError
// CHECK copy_addr
// CHECK: alloc_existential_box
// CHECK: project_existential_box
// CHECK: copy_addr
// CHECK: store
sil @unconditional_checked_cast_addr_address_only_type: $@convention(thin) (@in_guaranteed AddressOnlyError) -> @owned Error {
bb0(%0 : $*AddressOnlyError):
%1 = alloc_stack $Error
%2 = alloc_stack $AddressOnlyError
copy_addr %0 to [initialization] %2 : $*AddressOnlyError
unconditional_checked_cast_addr AddressOnlyError in %2 : $*AddressOnlyError to Error in %1 : $*Error
dealloc_stack %2 : $*AddressOnlyError
%8 = tuple ()
%9 = load %1 : $*Error
dealloc_stack %1 : $*Error
return %9 : $Error
}