SILGen: Fix for 'try?' leaking the error value #1740
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please fix |
|
|
||
| enum Markings { case Tuxedo, Tortoise } | ||
|
|
||
| class Cat : Equatable { |
There was a problem hiding this comment.
I like cats, but StdlibUnittest provides LifetimeTracked type for leak checking. And the harness automatically checks that LifetimeTracked.instances == 0 at the end of every test.
There was a problem hiding this comment.
Thanks! And I'm glad we both agree on the cat part too.
|
@swift-ci Please test |
If only this worked... |
slavapestov
force-pushed
the
try-optional-fix
branch
from
dad0052 to
ddeaecd
Compare
|
@swift-ci Please test |
The error is passed in to the catch block as a +1 value but we were just dropping it on the floor. Fixes https://bugs.swift.org/browse/SR-972
slavapestov
force-pushed
the
try-optional-fix
branch
from
ddeaecd to
cfb5c66
Compare
|
@swift-ci Please test |
|
I'm guessing this won't make it into Xcode 7.3 GM…? |
|
May I suggest this one being cherry-picked for the (potential) 2.2.1 release? It'll have big impact in our production code. Thanks for your consideration 🙇. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.