[Swift 2.2.1] [SILGen] Fix for 'try?' leaking the error value #1886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflejo
changed the title
|
@swift-ci test |
Reflejo
force-pushed
the
optional-try-leak
branch
from
92f3379 to
d38dbc1
Compare
Reflejo
changed the title
|
@swift-ci test |
|
|
||
| ErrorHandlingTests.test("tryOptional") { | ||
| expectEqual(LifetimeTracked(1), try? furball(false)) | ||
| expectEqual(Optional<LifetimeTracked>.none, try? furball(true)) |
There was a problem hiding this comment.
This test is written for Swift 3. I believe changing it to .None will make the test pass.
Reflejo
force-pushed
the
optional-try-leak
branch
from
d38dbc1 to
563859b
Compare
|
@tkremenek Tests should be passing now, apologies for the noise |
|
@swift-ci test |
Reflejo
force-pushed
the
optional-try-leak
branch
from
563859b to
3d82ffd
Compare
The error is passed in to the catch block as a +1 value but we were just dropping it on the floor. Fixes https://bugs.swift.org/browse/SR-972
Reflejo
force-pushed
the
optional-try-leak
branch
from
3d82ffd to
4349b89
Compare
|
@swift-ci test and merge |
|
Apparently cc @shahmishal |
|
@swift-ci test |
|
Makes sense for |
MaxDesiatov
pushed a commit
that referenced
this pull request
Oct 13, 2020
…-assertions Disable assertions for both target and host toolchain in 5.3 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Backport the fix for
try?memory leakage to Swift 2.2. This was the original PR to master: #1740. @tkremenek please consider merging it for a 2.2.x release.Resolved bug number: (SR-972)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.