[Swift 2.2.1][Swift runtime] Deallocation of partial class instances for Objective-C-derived classes #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-C-derived classes. Teach swift_deallocPartialClassInstance how to deal with classes that have pure Objective-C classes in their hierarchy. In such cases, we need to make sure a few things happen: 1) We deallocate via objc_release rather than swift_deallocClassInstance. 2) We only attempt to find an execute ivar destroyers for Swift-defined classes in the hierarchy 3) When we hit the most-derived pure Objective-C class, make sure that we only execute the dealloc of that class and not any of the subclasses (which would end up trying to destroy ivars again). Fixes rdar://problem/25023544.
|
@tkremenek please consider for a Swift 2.2 update. |
|
@swift-ci test |
tkremenek
changed the title
|
@swift-ci Please test |
|
Accepted for Swift 2.2.1. |
1 task
MaxDesiatov
added a commit
that referenced
this pull request
Oct 19, 2020
Build with Xcode GM on GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Backport the fix for deallocation of partial class instances for Objective-C-derived classes to Swift 2.2. We had fixed this regression from Swift 2.1 on mainline, but it's causing trouble in Swift 2.2 as well.
Resolved bug number: (SR-704)
Teach swift_deallocPartialClassInstance how to deal with classes that
have pure Objective-C classes in their hierarchy. In such cases, we
need to make sure a few things happen:
swift_deallocClassInstance.
Swift-defined classes in the hierarchy
only execute the dealloc of that class and not any of the subclasses
(which would end up trying to destroy ivars again).
Fixes rdar://problem/25023544 / SR-704.
@swift-ci Please test