Skip to content

[4.2][SR-7497][stdlib] Fix KeyPaths hashing #17479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2018
Merged

[4.2][SR-7497][stdlib] Fix KeyPaths hashing #17479

merged 3 commits into from
Jun 26, 2018

Conversation

lorentey
Copy link
Member

Cherry-pick from #17467 to the 4.2 branch; resolves issues with KeyPath hashing. Reviewed by @jckarter.

Resolves SR-7497.

dmcyk added 3 commits June 25, 2018 19:48
@dmcyk @lorentey
[stdlib] Fix key path components hashing.
1aa78ba 
Removes shadowed `hasher` argument in component hashing.

(cherry picked from commit ef91e2e)
@dmcyk @lorentey
[stdlib] Cover type difference in key path hash.
33a22a0 
Include type metadata pointer in hashing.

(cherry picked from commit 731b9b0)
@dmcyk @lorentey
[stdlib] Key path safe type hashing.
9e8acd2 
Uses ObjectIdentifier to extract metatype pointer,
instead of unsafe pointer casting.

(cherry picked from commit 3620ba3)
@lorentey
Copy link
Member Author

@swift-ci please test

@lorentey
Copy link
Member Author

cc @dmcyk

@lorentey lorentey merged commit 7dc489e into swiftlang:swift-4.2-branch Jun 26, 2018
@lorentey lorentey deleted the sr-7497-4.2 branch June 26, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentey @dmcyk