Start recovering from missing types in SIL deserialization #17564

jrose-apple · 2018-06-27T18:39:55Z

Now that @inlinable is a supported feature, we need to handle cases where a function is inlinable but it references some type that imports differently in different Swift versions. To start, handle the case where a SIL function's type is now invalid and therefore the entire function can't be imported. ~~This doesn't open up anything interesting yet, but it's a start.~~ This simple case is enough to fix problems when a SIL function is only referenced from a witness table and not actually used.

rdar://problem/40899824

Now that @inlinable is a supported feature, we need to handle cases where a function is inlinable but it references some type that imports differently in different Swift versions. To start, handle the case where a SIL function's type is now invalid and therefore the entire function can't be imported. This doesn't open up anything interesting yet, but it's a start. Part of rdar://problem/40899824

jrose-apple · 2018-06-27T18:40:02Z

@swift-ci Please test

jrose-apple · 2018-06-27T18:40:08Z

@swift-ci Please test source compatibility

jrose-apple · 2018-06-27T18:40:17Z

@swift-ci Please smoke test compiler performance

swift-ci · 2018-06-27T20:13:21Z

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for ReactiveCocoa

No regressions above thresholds

Debug
- debug brief
- debug detailed
Release
- release brief
- release detailed

Debug

debug brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name	old	new	delta	delta_pct
LLVM.NumLLVMBytesOutput	36,015,292	36,015,168	-124	-0.0%
time.swift-driver.wall	69.3s	69.6s	392.9ms	0.57%

debug detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	82,886	82,886	0	0.0%
AST.NumLoadedModules	12,485	12,485	0	0.0%
AST.NumTotalClangImportedEntities	253,787	253,787	0	0.0%
AST.NumUsedConformances	8,754	8,754	0	0.0%
IRModule.NumIRBasicBlocks	127,546	127,546	0	0.0%
IRModule.NumIRFunctions	75,825	75,825	0	0.0%
IRModule.NumIRGlobals	69,290	69,290	0	0.0%
IRModule.NumIRInsts	1,426,237	1,426,237	0	0.0%
IRModule.NumIRValueSymbols	129,827	129,827	0	0.0%
LLVM.NumLLVMBytesOutput	36,015,292	36,015,168	-124	-0.0%
SILModule.NumSILGenFunctions	44,348	44,348	0	0.0%
SILModule.NumSILOptFunctions	47,339	47,339	0	0.0%
Sema.NumConformancesDeserialized	351,370	351,370	0	0.0%
Sema.NumConstraintScopes	893,629	893,629	0	0.0%
Sema.NumDeclsDeserialized	2,068,712	2,068,712	0	0.0%
Sema.NumDeclsValidated	188,816	188,816	0	0.0%
Sema.NumFunctionsTypechecked	47,175	47,175	0	0.0%
Sema.NumGenericSignatureBuilders	80,123	80,123	0	0.0%
Sema.NumLazyGenericEnvironments	415,196	415,196	0	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	37,995	37,995	0	0.0%
Sema.NumLazyIterableDeclContexts	330,717	330,717	0	0.0%
Sema.NumTypesDeserialized	2,285,893	2,285,893	0	0.0%
Sema.NumTypesValidated	160,444	160,444	0	0.0%

Release

release brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name	old	new	delta	delta_pct
LLVM.NumLLVMBytesOutput	26,641,268	26,641,268	0	0.0%
time.swift-driver.wall	140.3s	140.2s	-30.2ms	-0.02%

release detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	8,857	8,857	0.0%
AST.NumLoadedModules	408	408	0.0%
AST.NumTotalClangImportedEntities	25,770	25,770	0.0%
AST.NumUsedConformances	8,760	8,760	0.0%
IRModule.NumIRBasicBlocks	148,662	148,662	0.0%
IRModule.NumIRFunctions	56,687	56,687	0.0%
IRModule.NumIRGlobals	54,037	54,037	0.0%
IRModule.NumIRInsts	1,220,955	1,220,955	0.0%
IRModule.NumIRValueSymbols	101,467	101,467	0.0%
LLVM.NumLLVMBytesOutput	26,641,268	26,641,268	0.0%
SILModule.NumSILGenFunctions	22,181	22,181	0.0%
SILModule.NumSILOptFunctions	35,901	35,901	0.0%
Sema.NumConformancesDeserialized	86,021	86,021	0.0%
Sema.NumConstraintScopes	793,754	793,754	0.0%
Sema.NumDeclsDeserialized	205,103	205,103	0.0%
Sema.NumDeclsValidated	59,866	59,866	0.0%
Sema.NumFunctionsTypechecked	10,716	10,716	0.0%
Sema.NumGenericSignatureBuilders	9,751	9,751	0.0%
Sema.NumLazyGenericEnvironments	32,279	32,279	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	4,556	4,556	0.0%
Sema.NumLazyIterableDeclContexts	20,590	20,590	0.0%
Sema.NumTypesDeserialized	268,868	268,868	0.0%
Sema.NumTypesValidated	33,026	33,026	0.0%

jrose-apple · 2018-06-27T22:42:49Z

@swift-ci Please test

swift-ci · 2018-06-27T22:45:32Z

Build failed
Swift Test Linux Platform
Git Sha - 2a89d5c

swift-ci · 2018-06-27T22:45:32Z

Build failed
Swift Test OS X Platform
Git Sha - 2a89d5c

jrose-apple · 2018-06-28T00:20:48Z

Full macOS tests

@swift-ci Please smoke test macOS

This is enough to let the test case in rdar://problem/40899824 pass, and any callers of this function already need to be able to handle a nullptr result. There's a lot more work to do in this area, but it's nice to get the simple things working again.

jrose-apple · 2018-06-28T00:24:48Z

@swift-ci Please test Linux

jrose-apple · 2018-06-28T00:25:01Z

@swift-ci Please smoke test macOS

swift-ci · 2018-06-28T00:26:42Z

Build failed
Swift Test Linux Platform
Git Sha - 71efe36d33e55e2078360bb2b6dc1ed7b102d500

slavapestov · 2018-06-28T00:27:07Z

validation-test/Serialization/rdar40899824.swift

+
+import rdar40899824Helper
+
+public protocol Proto: class {


Is the ": class" important for the test?

Oh, probably not. That's just how the original Radar's test case went.

…ly-idea Start recovering from missing types in SIL deserialization rdar://problem/40899824 (cherry picked from commit 747e318)

shajrawi

LGTM

…17591) Start recovering from missing types in SIL deserialization rdar://problem/40899824 (cherry picked from commit 747e318)

jrose-apple requested review from slavapestov and shajrawi June 27, 2018 18:39

jrose-apple mentioned this pull request Jun 27, 2018

[WIP] SIL serialization recovery for instructions #17570

Closed

jrose-apple force-pushed the recovery-is-a-SILly-idea branch from 8714ee4 to 422a2fe Compare June 28, 2018 00:20

jrose-apple force-pushed the recovery-is-a-SILly-idea branch from 422a2fe to 71efe36 Compare June 28, 2018 00:23

jrose-apple force-pushed the recovery-is-a-SILly-idea branch from 71efe36 to f1b347c Compare June 28, 2018 00:24

swiftlang deleted a comment from swift-ci Jun 28, 2018

slavapestov approved these changes Jun 28, 2018

View reviewed changes

jrose-apple merged commit 747e318 into swiftlang:master Jun 28, 2018

jrose-apple deleted the recovery-is-a-SILly-idea branch June 28, 2018 16:34

shajrawi reviewed Jun 28, 2018

View reviewed changes

jrose-apple added a commit that referenced this pull request Jun 28, 2018

Merge pull request #17564 from jrose-apple/recovery-is-a-SILly-idea (#…

ff66b79

…17591) Start recovering from missing types in SIL deserialization rdar://problem/40899824 (cherry picked from commit 747e318)

Start recovering from missing types in SIL deserialization #17564

Start recovering from missing types in SIL deserialization #17564

Uh oh!

Conversation

jrose-apple commented Jun 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrose-apple commented Jun 27, 2018

Uh oh!

jrose-apple commented Jun 27, 2018

Uh oh!

jrose-apple commented Jun 27, 2018

Uh oh!

swift-ci commented Jun 27, 2018

Build comment file:

Summary for master smoketest

Debug

debug brief

debug detailed

Release

release brief

release detailed

Uh oh!

jrose-apple commented Jun 27, 2018

Uh oh!

swift-ci commented Jun 27, 2018

Uh oh!

swift-ci commented Jun 27, 2018

Uh oh!

jrose-apple commented Jun 28, 2018

Uh oh!

jrose-apple commented Jun 28, 2018

Uh oh!

jrose-apple commented Jun 28, 2018

Uh oh!

swift-ci commented Jun 28, 2018

Uh oh!

slavapestov Jun 28, 2018

Choose a reason for hiding this comment

Uh oh!

jrose-apple Jun 28, 2018

Choose a reason for hiding this comment

Uh oh!

shajrawi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jrose-apple commented Jun 27, 2018 •

edited

Loading