[WIP] SIL serialization recovery for instructions #17570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that @inlinable is a supported feature, we need to handle cases where a function is inlinable but it references some type that imports differently in different Swift versions. To start, handle the case where a SIL function's type is now invalid and therefore the entire function can't be imported. This doesn't open up anything interesting yet, but it's a start. Part of rdar://problem/40899824
When instructions in an inlinable SIL function can't be deserialized, drop the body of the function and make it external. This commit tests that behavior by making several simple classes of SILInstruction recover from their types not being deserializable. Still to do: - Many more instruction kinds - Cascading failures: if a 'shared' function can't be deserialized, anything that references it should also fail. - Produce an error in SIL diagnostics if the function that got dropped was an always-emit-into-client function, and thus cannot be marked external. Part of rdar://problem/40899824
slavapestov
reviewed
Jun 28, 2018
| @@ -1538,16 +1557,21 @@ bool SILDeserializer::readSILInstruction(SILFunction *Fn, SILBasicBlock *BB, | |||
| case SILInstructionKind::StringLiteralInst: { | |||
| Identifier StringVal = MF->getIdentifier(ValID); | |||
| auto encoding = fromStableStringEncoding(Attr); | |||
| if (!encoding) return true; | |||
| if (!encoding) { | |||
| MF->error(); | |||
There was a problem hiding this comment.
Should MF->error() be [[unreachable]] or whatever?
There was a problem hiding this comment.
:-/ It's stateful at the moment—if you error early on in loading the module, it records that information for use later and compilation can keep going. I should probably go rework that at some point so that the recoverable parts go through a different entry point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instructions in an inlinable SIL function can't be deserialized, drop the body of the function and make it external. This commit tests that behavior by making several simple classes of SILInstruction recover from their types not being deserializable.
Builds on #17564; this is the more interesting part.
Still to do:
Part of rdar://problem/40899824