[4.2] Prefer RawRepresentable fix-its that don't require an extra conversion #17724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer RawRepresentable fix-its that don't require an extra conversion https://bugs.swift.org/browse/SR-8150 (cherry picked from commit 9116f95)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The fix-it for automatically inserting
.rawValuewhen necessary was producing an unnecessary and possibly dangerous conversion when more than one numeric type was accepted by a method. In addition, the fix-it itself was syntactically invalid when the expression was a single, unlabeled call argument. This change fixes both of those issues by stripping parentheses and preferring an overload that exactly matches a raw or wrapping type.Scope: Affects error diagnostics only, and even then only cases where we would have already decided that this was the right message to emit. This does come up in migration due to new
NS_TYPED_ENUMs.Issue: SR-8150 / rdar://problem/41725207
Risk: Low. It's mostly the same logic as before, just without an early exit.
Testing: Added compiler regression tests.
Reviewed by: @DougGregor