Prefer RawRepresentable fix-its that don't require an extra conversion #17714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were being put outside the call parentheses instead of inside. We even had tests for this; I just got them wrong. https://bugs.swift.org/browse/SR-8150
That is, if a type has a raw value of Int, and the function being called has overloads for both Int and UInt, we always want to offer a fix-it that leads to the 'Int' overload, not insert a conversion to UInt that might be incorrect. More https://bugs.swift.org/browse/SR-8150.
|
@swift-ci Please test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jul 3, 2018
Prefer RawRepresentable fix-its that don't require an extra conversion https://bugs.swift.org/browse/SR-8150 (cherry picked from commit 9116f95)
jrose-apple
added a commit
that referenced
this pull request
Jul 4, 2018
Prefer RawRepresentable fix-its that don't require an extra conversion https://bugs.swift.org/browse/SR-8150 (cherry picked from commit 9116f95)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes around RawRepresentable fix-its:
Fix RawRepresentable fix-its for single unlabeled arguments
They were being put outside the call parentheses instead of inside. We even had tests for this; I just got them wrong.
Prefer RawRepresentable fix-its that don't require an extra conversion
That is, if a type has a raw value of Int, and the function being called has overloads for both Int and UInt, we always want to offer a fix-it that leads to the 'Int' overload, not insert a conversion to UInt that might be incorrect.
SR-8150 / rdar://problem/41725207