Handle stray LoadExprs in RawRepresentable fix-its #17804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple possible overloads for a call, the partially- type-checked argument expression might end up with a LoadExpr outside of the call ParenExpr instead of inside it. Account for this in a one- off way for the 'rawValue' / 'init(rawValue:)' fix-its. Yet more https://bugs.swift.org/browse/SR-8150
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
rudkx
approved these changes
Jul 6, 2018
|
@xedin said he might have a more general fix, so I'll hold off for now. |
|
Yes! I'm about to create a PR for that which changes CSApply/ASTVerifier to make sure that immediate paren/force-value expressions are always outside of load. |
|
We're going to use this as a definite fix for 4.2 and continue investigating the rest of it on master. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jul 9, 2018
When there are multiple possible overloads for a call, the partially- type-checked argument expression might end up with a LoadExpr outside of the call ParenExpr instead of inside it. Account for this in a one- off way for the 'rawValue' / 'init(rawValue:)' fix-its. Yet more https://bugs.swift.org/browse/SR-8150 (cherry picked from commit c468ca1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple possible overloads for a call, the partially-type-checked argument expression might end up with a LoadExpr outside of the call ParenExpr instead of inside it. Account for this in a one- off way for the
rawValue/init(rawValue:)fix-its.Yet more SR-8150 / rdar://problem/41725207. (Follow-up to #17714.)