[4.2] Handle stray LoadExprs in RawRepresentable fix-its #17847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple possible overloads for a call, the partially- type-checked argument expression might end up with a LoadExpr outside of the call ParenExpr instead of inside it. Account for this in a one- off way for the 'rawValue' / 'init(rawValue:)' fix-its. Yet more https://bugs.swift.org/browse/SR-8150 (cherry picked from commit c468ca1)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The fix-it for automatically inserting
.rawValueis still syntactically invalid when the expression is a single, unlabeled call argument that references a mutable property or variable. Recognize the unusual recovery AST that gets built in this situation and make sure the fix-it goes in the right place.Scope: Affects error diagnostics only, and even then only cases where we would have already decided that this was the right message to emit. This does come up in migration due to new
NS_TYPED_ENUMs.Issue: SR-8150 / rdar://problem/41725207 (again)
Risk: Very low. There's one additional special case that then immediately goes back to the existing code path.
Testing: Added compiler regression tests.
Reviewed by: @rudkx