[PrintAsObjC] Handle generic typealiases #18941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
I'm suspicious now of all the other places that are using |
|
Build failed |
jrose-apple
force-pushed
the
the-underlying-problem
branch
from
f04a3ce to
a7b507a
Compare
(either explicitly generic ones, or those embedded in generic contexts) Previously we tried to look at the typealias decl's underlying type, but that might have generic parameters in it. Oops. Use the NameAliasType's desugared type instead. Also, drop half-baked support for `@objc typealias`, which isn't supported. (It's not an unreasonable feature, but the bits that were there weren't implemented correctly.) rdar://problem/43347303
|
macOS full test @swift-ci Please smoke test |
slavapestov
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(either explicitly generic ones, or those embedded in generic contexts)
Previously we tried to look at the typealias decl's underlying type, but that might have generic parameters in it. Oops. Use the NameAliasType's desugared type instead.
Also, drop half-baked support for
@objc typealias, which isn't supported. (It's not an unreasonable feature, but the bits that were there weren't implemented correctly.)rdar://problem/43347303