[PrintAsObjC] Look through "compatibility" typealiases #20027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These handle imported types that have been renamed in a /later/ Swift version than the one being used; for consistency when deserializing from a swiftmodule, the latest name is always used. This is important because it might mean we can avoid importing the framework that a name comes from; a forward declaration might be sufficient if it's an ObjC class or protocol. rdar://problem/45491607
|
@graydon, feel free to ask questions for reviewing purposes. I picked you mostly because you've done a little bit of Clang Importer stuff. |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
DougGregor
approved these changes
Oct 24, 2018
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Oct 25, 2018
These handle imported types that have been renamed in a /later/ Swift version than the one being used; for consistency when deserializing from a swiftmodule, the latest name is always used. This is important because it might mean we can avoid importing the framework that a name comes from; a forward declaration might be sufficient if it's an ObjC class or protocol. rdar://problem/45491607 (cherry picked from commit e34a6a1)
jrose-apple
added a commit
that referenced
this pull request
Oct 25, 2018
These handle imported types that have been renamed in a /later/ Swift version than the one being used; for consistency when deserializing from a swiftmodule, the latest name is always used. This is important because it might mean we can avoid importing the framework that a name comes from; a forward declaration might be sufficient if it's an ObjC class or protocol. rdar://problem/45491607 (cherry picked from commit e34a6a1)
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Oct 26, 2018
These handle imported types that have been renamed in a /later/ Swift version than the one being used; for consistency when deserializing from a swiftmodule, the latest name is always used. This is important because it might mean we can avoid importing the framework that a name comes from; a forward declaration might be sufficient if it's an ObjC class or protocol. rdar://problem/45491607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These handle imported types that have been renamed in a later Swift version than the one being used; for consistency when deserializing from a swiftmodule, the latest name is always used. This is important because it might mean we can avoid importing the framework that a name comes from; a forward declaration might be sufficient if it's an ObjC class or protocol.
Fallout from #18941 (oops).
rdar://problem/45491607