[stdlib] Obsolete various compatibility shims in 5.0 #19008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
moiseev
approved these changes
Aug 28, 2018
| var c = CollectionOfOne<OpaqueValue<Int>>(OpaqueValue(42)) | ||
| expectCrashLater() | ||
| ${operation} | ||
| let collectionOfOneIndexTests: [(String,(inout CollectionOfOne<OpaqueValue<Int>>,Int)->Void,[Int])] = [ |
| var c = EmptyCollection<OpaqueValue<Int>>() | ||
| expectCrashLater() | ||
| ${operation} | ||
| let emptyCollectionIndexTests: [(String,(inout EmptyCollection<OpaqueValue<Int>>,Int)->Void)] = [ |
There was a problem hiding this comment.
s/Void/() would make the line shorter =)
There was a problem hiding this comment.
I think () for arguments, Void for return is our style tho.
|
Should we squash the tiny commits? |
|
I'll just squash the whole thing on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking another run at this...
It's a lot of changes but mainly because we template out a zillion variation tests to eliminate modifiers on Slice from the templated tests..