Skip to content

[stdlib] Remove a couple of obsoleted-in-4.0 methods #22123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

airspeedswift
Copy link
Member

Now that 3.0 support was dropped. Missed these in #19008. Causing problems reported here.

Note, the ABI checker changes are false positives. These have not been callable since ABI stability was declared, so not ABI.

@airspeedswift airspeedswift requested a review from moiseev January 25, 2019 22:03
@airspeedswift
Copy link
Member Author

@swift-ci please smoke test and merge

Copy link
Contributor

@moiseev moiseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@swift-ci swift-ci merged commit bd4e2ad into swiftlang:master Jan 25, 2019
@jrose-apple
Copy link
Contributor

Unfortunately this isn't actually going to be causing those problems. Jens is complaining about a deprecation, not an obsoletion.

@moiseev
Copy link
Contributor

moiseev commented Jan 25, 2019

We don't need these guys in our ABI regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants