[index] Improvements on how conformances are recorded #19043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query for the local conformances of a DeclContext and record conformances of functions that are defined in other types as 'implicit' overrides, with the type that introduces the conformance as container symbol. This allows more accurate index data, and avoids needing to query for all protocol requirements, which is expensive to calculate.
|
@swift-ci smoke test |
|
@swift-ci smoke test |
benlangmuir
approved these changes
Aug 29, 2018
| for (auto Overriden: getOverriddenDecls(D, /*IncludeProtocolReqs=*/!isSystemModule)) { | ||
| if (addRelation(Info, (SymbolRoleSet) SymbolRole::RelationOverrideOf, Overriden)) | ||
| return false; | ||
| for (auto Overriden: getOverriddenDecls(D, /*IncludeProtocolReqs=*/false)) { |
There was a problem hiding this comment.
We should change the default value for IncludeProtocolReqs in getOverriddenDecls to false or remove the default value entirely to avoid accidentally adding this kind of code in future.
There was a problem hiding this comment.
Unfortunately the migrator also depends on this (in APIDiffMigratorPass::getRelatedDiffItems()), I intend to remove it after the migrator is changed as well (rdar://43844914)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query for the local conformances of a DeclContext and record conformances of
functions that are defined in other types as 'implicit' overrides, with
the type that introduces the conformance as container symbol.
This allows more accurate index data, and avoids needing to query for all
protocol requirements, which is expensive to calculate.