-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[index] Improvements on how conformances are recorded #19043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| // RUN: %target-swift-ide-test -print-indexed-symbols -source-filename %s | %FileCheck %s | ||
|
|
||
| protocol P1 { // CHECK: [[@LINE]]:10 | protocol/Swift | P1 | [[P1_USR:.*]] | Def | | ||
| func foo() // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[P1_foo_USR:.*]] | Def | ||
| } | ||
|
|
||
| struct DirectConf: P1 { // CHECK: [[@LINE]]:8 | struct/Swift | DirectConf | [[DirectConf_USR:.*]] | Def | ||
| func foo() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[DirectConf_foo_USR:.*]] | Def,RelChild,RelOver | rel: 2 | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[P1_foo_USR]] | ||
| // CHECK-NEXT: RelChild | struct/Swift | DirectConf | [[DirectConf_USR]] | ||
| } | ||
|
|
||
| struct ConfFromExtension {} | ||
| extension ConfFromExtension: P1 { // CHECK: [[@LINE]]:11 | extension/ext-struct/Swift | ConfFromExtension | [[ConfFromExtension_ext_USR:.*]] | Def | ||
| func foo() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[ConfFromExtension_ext_foo_USR:.*]] | Def,RelChild,RelOver | rel: 2 | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[P1_foo_USR]] | ||
| // CHECK-NEXT: RelChild | extension/ext-struct/Swift | ConfFromExtension | [[ConfFromExtension_ext_USR]] | ||
| } | ||
|
|
||
| struct ImplicitConfFromExtension { // CHECK: [[@LINE]]:8 | struct/Swift | ImplicitConfFromExtension | [[ImplicitConfFromExtension_USR:.*]] | Def | ||
| func foo() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[ImplicitConfFromExtension_foo_USR:.*]] | Def,RelChild | rel: 1 | ||
| // CHECK-NEXT: RelChild | struct/Swift | ImplicitConfFromExtension | [[ImplicitConfFromExtension_USR]] | ||
| } | ||
| extension ImplicitConfFromExtension: P1 { // CHECK: [[@LINE]]:11 | extension/ext-struct/Swift | ImplicitConfFromExtension | [[ImplicitConfFromExtension_USR:.*]] | Def | ||
| // CHECK: [[@LINE-1]]:11 | instance-method/Swift | foo() | [[ImplicitConfFromExtension_foo_USR]] | Impl,RelOver,RelCont | rel: 2 | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[P1_foo_USR]] | ||
| // CHECK-NEXT: RelCont | extension/ext-struct/Swift | ImplicitConfFromExtension | [[ImplicitConfFromExtension_USR]] | ||
| } | ||
|
|
||
| class BaseConfFromBase { // CHECK: [[@LINE]]:7 | class/Swift | BaseConfFromBase | [[BaseConfFromBase_USR:.*]] | Def | ||
| func foo() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[BaseConfFromBase_foo_USR:.*]] | Def,Dyn,RelChild | rel: 1 | ||
| // CHECK-NEXT: RelChild | class/Swift | BaseConfFromBase | [[BaseConfFromBase_USR]] | ||
| } | ||
| class SubConfFromBase: BaseConfFromBase, P1 { // CHECK: [[@LINE]]:7 | class/Swift | SubConfFromBase | [[SubConfFromBase_USR:.*]] | Def | ||
| // CHECK: [[@LINE-1]]:7 | instance-method/Swift | foo() | [[BaseConfFromBase_foo_USR]] | Impl,RelOver,RelCont | rel: 2 | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[P1_foo_USR]] | ||
| // CHECK-NEXT: RelCont | class/Swift | SubConfFromBase | [[SubConfFromBase_USR]] | ||
| } | ||
|
|
||
| protocol P2 { // CHECK: [[@LINE]]:10 | protocol/Swift | P2 | [[P2_USR:.*]] | Def | | ||
| func foo() // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[P2_foo_USR:.*]] | Def | ||
| } | ||
| extension P2 { // CHECK: [[@LINE]]:11 | extension/ext-protocol/Swift | P2 | [[P2_ext_USR:.*]] | Def | ||
| func foo() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[P2_ext_foo_USR:.*]] | Def,Dyn,RelChild,RelOver | rel: 2 | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[P2_foo_USR]] | ||
| // CHECK-NEXT: RelChild | extension/ext-protocol/Swift | P2 | [[P2_ext_USR]] | ||
| } | ||
|
|
||
| struct ConfFromDefaultImpl: P2 { // CHECK: [[@LINE]]:8 | struct/Swift | ConfFromDefaultImpl | [[ConfFromDefaultImpl_USR:.*]] | Def | ||
| // CHECK: [[@LINE-1]]:8 | instance-method/Swift | foo() | [[P2_ext_foo_USR]] | Impl,RelOver,RelCont | rel: 2 | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[P2_foo_USR]] | ||
| // CHECK-NEXT: RelCont | struct/Swift | ConfFromDefaultImpl | [[ConfFromDefaultImpl_USR]] | ||
| } | ||
|
|
||
| protocol P3 { | ||
| func meth1() // CHECK: [[@LINE]]:8 | instance-method/Swift | meth1() | [[P3_meth1_USR:.*]] | Def | ||
| func meth2() // CHECK: [[@LINE]]:8 | instance-method/Swift | meth2() | [[P3_meth2_USR:.*]] | Def | ||
| } | ||
|
|
||
| class BaseMultiConf { | ||
| func meth2() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | meth2() | [[BaseMultiConf_meth2_USR:.*]] | Def | ||
| } | ||
| extension SubMultiConf { | ||
| func meth1() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | meth1() | [[SubMultiConf_ext_meth1_USR:.*]] | Def | ||
| } | ||
| class SubMultiConf: BaseMultiConf,P2,P1,P3 { // CHECK: [[@LINE]]:7 | class/Swift | SubMultiConf | [[SubMultiConf_USR:.*]] | Def | ||
| // CHECK: [[@LINE-1]]:7 | instance-method/Swift | foo() | [[P2_ext_foo_USR]] | Impl,RelOver,RelCont | rel: 2 | ||
| // CHECK-NEXT RelOver | instance-method/Swift | foo() | [[P2_foo_USR]] | ||
| // CHECK-NEXT RelCont | class/Swift | SubMultiConf | [[SubMultiConf_USR]] | ||
| // CHECK: [[@LINE-4]]:7 | instance-method/Swift | foo() | [[P2_ext_foo_USR]] | Impl,RelOver,RelCont | rel: 2 | ||
| // CHECK-NEXT RelOver | instance-method/Swift | foo() | [[P1_foo_USR]] | ||
| // CHECK-NEXT RelCont | class/Swift | SubMultiConf | [[SubMultiConf_USR]] | ||
| // CHECK: [[@LINE-7]]:7 | instance-method/Swift | meth1() | [[SubMultiConf_ext_meth1_USR]] | Impl,RelOver,RelCont | rel: 2 | ||
| // CHECK-NEXT RelOver | instance-method/Swift | meth1() | [[P3_meth1_USR]] | ||
| // CHECK-NEXT RelCont | class/Swift | SubMultiConf | [[SubMultiConf_USR]] | ||
| // CHECK: [[@LINE-10]]:7 | instance-method/Swift | meth2() | [[BaseMultiConf_meth2_USR]] | Impl,RelOver,RelCont | rel: 2 | ||
| // CHECK-NEXT RelOver | instance-method/Swift | meth2() | [[P3_meth2_USR]] | ||
| // CHECK-NEXT RelCont | class/Swift | SubMultiConf | [[SubMultiConf_USR]] | ||
| // CHECK-NOT: [[@LINE-13]]:7 | instance-method | ||
| } | ||
|
|
||
| protocol InheritingP: P1 { // CHECK: [[@LINE]]:10 | protocol/Swift | InheritingP | [[InheritingP_USR:.*]] | Def | ||
| // FIXME: Should have override relation with P1.foo() | ||
| func foo() // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[InheritingP_foo_USR:.*]] | Def,Dyn,RelChild | rel: 1 | ||
| // CHECK-NEXT: RelChild | protocol/Swift | InheritingP | [[InheritingP_USR]] | ||
| } | ||
|
|
||
| struct DirectConf2: InheritingP { // CHECK: [[@LINE]]:8 | struct/Swift | DirectConf2 | [[DirectConf2_USR:.*]] | Def | ||
| // FIXME: Should only override InheritingP.foo() | ||
| func foo() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[DirectConf2_foo_USR:.*]] | Def,RelChild,RelOver | rel: 3 | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[InheritingP_foo_USR]] | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[P1_foo_USR]] | ||
| // CHECK-NEXT: RelChild | struct/Swift | DirectConf2 | [[DirectConf2_USR]] | ||
| } | ||
|
|
||
| extension InheritingP { // CHECK: [[@LINE]]:11 | extension/ext-protocol/Swift | InheritingP | [[InheritingP_USR:.*]] | Def | ||
| // FIXME: Should only override InheritingP.foo() | ||
| func foo() {} // CHECK: [[@LINE]]:8 | instance-method/Swift | foo() | [[InheritingP_ext_foo_USR:.*]] | Def,Dyn,RelChild,RelOver | rel: 3 | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[InheritingP_foo_USR]] | ||
| // CHECK-NEXT: RelOver | instance-method/Swift | foo() | [[P1_foo_USR]] | ||
| // CHECK-NEXT: RelChild | extension/ext-protocol/Swift | InheritingP | [[InheritingP_USR]] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the default value for
IncludeProtocolReqsingetOverriddenDeclsto false or remove the default value entirely to avoid accidentally adding this kind of code in future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the migrator also depends on this (in APIDiffMigratorPass::getRelatedDiffItems()), I intend to remove it after the migrator is changed as well (rdar://43844914)