Skip to content

[test] Fix target-based reflection tests for real #19098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

jrose-apple
Copy link
Contributor

Follow-up to #19031, itself a response to mistakes in #18966.

  • Hard-link %target-swift-reflection-test into %t/ for %target-run implementations that copy executables, like remote-run.
  • Use DYLD_LIBRARY_PATH to undo that for %target-run implementations that run the executable in place (host and simulators)

rdar://problem/43809613

- Hard-link %target-swift-reflection-test into %t/ for %target-run
  implementations that copy executables, like remote-run.
- Use DYLD_LIBRARY_PATH to undo that for %target-run implementations
  that run the executable in place (host and simulators)

rdar://problem/43809613
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple jrose-apple merged commit e3f3e93 into swiftlang:master Sep 4, 2018
@jrose-apple jrose-apple deleted the upon-reflection branch September 4, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant