[test] Yet more tweaks to remote-run #19130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really we ought to clear out "%t*", but running wildcards with 'rm' scares me a little too much for that. This still fixes a handful of tests that were relying on %t being an empty directory. Note that this doesn't interfere with generated files persisting between %target-run invocations; they'll be downloaded and then re-uploaded as long as they're mentioned in the invocation.
Copy %target-swift-reflection-test into %t instead of using a hard link. The problem with hard links is that they can be overwritten when the test fails, which would then truncate the original executable to an empty file!
|
@swift-ci Please test |
This was referenced Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #18966 and #19098 to continue improving the behavior of remote-run:
%ton the remote machine, so we don't run into artifacts from the last run.%target-swift-reflection-testinto%tinstead of using a hard link. The problem with hard links is that they can be overwritten when the test fails, which would then truncate the original executable to an empty file!