Skip to content

Rdar 44142091 fix without test #19314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davidungar
Copy link
Contributor

@davidungar davidungar commented Sep 14, 2018

Today, response files include extra, bogus quotes, for example: ""foo.swift"". This PR removes the superfluous and harmful extra quotes, so that spaces in file names in response files work.
It fixes rdar://44142091, but cannot be tested easily until #19313 lands. At that point, I will submit another PR with the test, which I have already written:

// RUN: %empty-directory(%t)
// RUN: touch "%t/f i l e.swift"
//
// RUN: %swiftc_driver -driver-force-response-files -typecheck  "%t/f i l e.swift"

Or, if preferred, PR 19313 can land first, then I can add the test to this PR.

@davidungar
Copy link
Contributor Author

@swift-ci please test

escapeAndPrintString(OS, arg);
OS << "\" ";
OS << " ";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…ouch. Good catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jrose-apple
Copy link
Contributor

This might also be something worth bringing to the 4.2 branch. It's a very local change that will fix a potentially widespread problem.

@davidungar davidungar merged commit 3a8d4dc into swiftlang:master Sep 14, 2018
@jrose-apple
Copy link
Contributor

(although do wait for the test for that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants