Fix response file quote bug, add flag for testing, add tests. #19321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please nominate |
|
Build failed |
|
Build failed |
|
Must be an absent #include on the 4.2 branch. |
|
LGTM besides the #include issue, ready for Ted's approval. |
|
@swift-ci please test |
|
Thanks, @jrose-apple . |
|
Build failed |
|
Build failed |
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Sep 14, 2018
…spaces-in-files-in-resp-files-swift-4.2 Fix response file quote bug, add flag for testing, add tests.
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Sep 20, 2018
…spaces-in-files-in-resp-files-swift-4.2 Fix response file quote bug, add flag for testing, add tests.
davidungar
pushed a commit
that referenced
this pull request
Sep 20, 2018
…s-with-spaces-Swift-5 Merge pull request #19321 from davidungar/rdar-44458502-fix-spaces-in-long-paths
davidungar
deleted the
rdar-44458502-fix-spaces-in-files-in-resp-files-swift-4.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes response file bug when spaces are in file paths.
Scope of issue: Build breakage when paths are too long and contain spaces.
Origination: Typo when written, as near as I can tell.
Risk: Minimal. I can't see how getting the quotes right could introduce a bug.
Reviewed by: Jordan Rose
Testing: Normal regression tests.
Radar: rdar://44142091
Details:
Recently, response files were added to the compiler. If the project is located in a path that is long enough, so that the arguments to a tool (frontend, linker) might be too long, the driver passes them in a file instead, called a "response file". In order for the tool to accurately reparse the reponse file contents into a sequence of arguments, each argument in the response file must be enclosed in quotes in case that argument contains a space character.
However, when the response file mechanism was added, extra quotes were mistakenly used. For instance, the argument gets written to the response file as <""part1 part2.swift"">.
The effect is to cause projects using response files to break.
This PR:
It combines PRs from master:
#19316
#19314
#19313