Adds test for fix to spaces in filenames in response files. #19316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
jrose-apple
reviewed
Sep 14, 2018
| // RUN: %empty-directory(%t) | ||
| // RUN: touch "%t/f i l e.swift" | ||
| // | ||
| // RUN: %swiftc_driver -driver-force-response-files -typecheck "%t/f i l e.swift" |
There was a problem hiding this comment.
This needs to be %target-build-swift, since it's going to actually run the frontend. I suppose you could use -parse instead of -typecheck and then it doesn't need the standard library or anything.
There was a problem hiding this comment.
Thanks! I've made those changes.
|
@swift-ci please smoke test |
jrose-apple
approved these changes
Sep 14, 2018
This was referenced Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for files with spaces in response files. rdar://19314
Uses new testing flag added in #19313