Skip to content

Generalize extra inhabitants of tuples. #19340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2018
Merged

Generalize extra inhabitants of tuples. #19340

merged 1 commit into from
Sep 21, 2018

Conversation

jckarter
Copy link
Contributor

Like we did for structs, make it so that tuple types can also get extra inhabitants from whichever element with the most, not only the first. This lets us move all of the extra inhabitant handling functionality between structs and tuples in IRGen up to the common RecordTypeInfo CRTP base.

@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e45a5242d776f83629dc123b52f0752f978015a8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e45a5242d776f83629dc123b52f0752f978015a8

@jckarter
Copy link
Contributor Author

@swift-ci Please clean test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e45a5242d776f83629dc123b52f0752f978015a8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e45a5242d776f83629dc123b52f0752f978015a8

@jckarter jckarter force-pushed the generalize-tuple-extra-inhabitants branch 3 times, most recently from 72ae0aa to 592250f Compare September 18, 2018 01:14
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e45a5242d776f83629dc123b52f0752f978015a8

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e45a5242d776f83629dc123b52f0752f978015a8

@jckarter
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 592250f17e0f0e0e9bca5f6005f50d48e870467d

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 592250f17e0f0e0e9bca5f6005f50d48e870467d

@jckarter jckarter force-pushed the generalize-tuple-extra-inhabitants branch from 592250f to c653215 Compare September 18, 2018 16:57
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 592250f17e0f0e0e9bca5f6005f50d48e870467d

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 592250f17e0f0e0e9bca5f6005f50d48e870467d

@jckarter
Generalize extra inhabitants of tuples.
93d8599 
Like we did for structs, make it so that tuple types can also get extra inhabitants from whichever element with the most, not only the first. This lets us move all of the extra inhabitant handling functionality between structs and tuples in IRGen up to the common RecordTypeInfo CRTP base.
@jckarter jckarter force-pushed the generalize-tuple-extra-inhabitants branch from c653215 to 93d8599 Compare September 20, 2018 22:40
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c65321524a49fa772088c3e2db0e4107865e6b8c

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c65321524a49fa772088c3e2db0e4107865e6b8c

@jckarter jckarter merged commit c87d2a8 into swiftlang:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov Awaiting requested review from slavapestov

@rjmccall rjmccall Awaiting requested review from rjmccall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckarter @swift-ci