Skip to content

Generalize extra inhabitants of tuples. #19340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions foo.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@

enum SinglePayloadGenericEnumWithDefaultMirror<T, U> {
case Well
case Faucet
case Pipe(T, U)
}

func foo(x: Int, y: [Int], out: (SinglePayloadGenericEnumWithDefaultMirror<Int, [Int]>) -> ()) {
out(.Well)
out(.Faucet)
out(.Pipe(x, y))
}

func bar<T, U>(_ x: SinglePayloadGenericEnumWithDefaultMirror<T, U>) {
switch x {
case .Well:
print("well")
case .Faucet:
print("faucet")
case .Pipe:
print("pipe")
}
}

foo(x: 1, y: [1,2,3], out: bar)
11 changes: 8 additions & 3 deletions include/swift/ABI/Metadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,7 @@ struct TargetTupleTypeMetadata : public TargetMetadata<Runtime> {
using StoredSize = typename Runtime::StoredSize;
TargetTupleTypeMetadata() = default;
constexpr TargetTupleTypeMetadata(const TargetMetadata<Runtime> &base,
StoredSize numElements,
uint32_t numElements,
TargetPointer<Runtime, const char> labels)
: TargetMetadata<Runtime>(base),
NumElements(numElements),
Expand Down Expand Up @@ -1487,14 +1487,19 @@ struct TargetTupleTypeMetadata : public TargetMetadata<Runtime> {
return getElements()[i];
}

static constexpr StoredSize OffsetToNumElements = sizeof(TargetMetadata<Runtime>);

static constexpr StoredSize getOffsetToNumElements();
static bool classof(const TargetMetadata<Runtime> *metadata) {
return metadata->getKind() == MetadataKind::Tuple;
}
};
using TupleTypeMetadata = TargetTupleTypeMetadata<InProcess>;

template <typename Runtime>
constexpr inline auto
TargetTupleTypeMetadata<Runtime>::getOffsetToNumElements() -> StoredSize {
return offsetof(TargetTupleTypeMetadata<Runtime>, NumElements);
}

template <typename Runtime> struct TargetProtocolDescriptor;

#if SWIFT_OBJC_INTEROP
Expand Down
1 change: 0 additions & 1 deletion include/swift/ABI/MetadataValues.h
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ class TargetExtraInhabitantFlags {

public:
constexpr TargetExtraInhabitantFlags() : Data(0) {}

/// The number of extra inhabitants in the type's representation.
int getNumExtraInhabitants() const { return Data & NumExtraInhabitantsMask; }

Expand Down
4 changes: 2 additions & 2 deletions include/swift/Remote/MetadataReader.h
Original file line number Diff line number Diff line change
Expand Up @@ -1087,8 +1087,8 @@ class MetadataReader {
return _readMetadata<TargetStructMetadata>(address);
case MetadataKind::Tuple: {
auto numElementsAddress = address +
TargetTupleTypeMetadata<Runtime>::OffsetToNumElements;
StoredSize numElements;
TargetTupleTypeMetadata<Runtime>::getOffsetToNumElements();
uint32_t numElements;
if (!Reader->readInteger(RemoteAddress(numElementsAddress),
&numElements))
return nullptr;
Expand Down
Loading