Skip to content

[test] Test compiling the overlay swiftinterfaces to binary form #19438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2018
Merged

[test] Test compiling the overlay swiftinterfaces to binary form #19438

merged 1 commit into from
Oct 1, 2018

Conversation

jrose-apple
Copy link
Contributor

Let's not regress!

@jrose-apple
Copy link
Contributor Author

I really hope this list isn't platform-dependent, or else I have to make my expected output checking cleverer.

@swift-ci Please test

harlanhaskins
harlanhaskins approved these changes Sep 21, 2018
View reviewed changes
validation-test/ModuleInterface/verify_all_overlays.swift Outdated
@@ -0,0 +1,25 @@
// RUN: %empty-directory(%t)
// RUN: for x in %platform-sdk-overlay-dir/*.swiftinterface; do [[ $(basename "$x") = Swift.swiftinterface || $(basename "$x") = simd.swiftinterface ]] && continue; %target-swift-frontend "$x" -emit-module -o %t/$(basename "${x/.*}").swiftmodule -disable-objc-attr-requires-foundation-module -enable-resilience -Fsystem %sdk/System/Library/PrivateFrameworks/ || echo -swift-version 4 $(basename "$x") >> %t/failures.txt; done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a lot for a RUN line, but I suppose it's alright.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-( Yeah. I could pull it out into some kind of script, I guess? But it's also in SIL/verify_all_overlays.sil.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7960ab8448e85f4d69bd6a0998a3a9d0debb8728

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7960ab8448e85f4d69bd6a0998a3a9d0debb8728

@jrose-apple
Copy link
Contributor Author 

Command Output (stdout):
--
1a2
> CoreGraphics.swiftinterface
5c6
< SwiftLang.swiftinterface
---
> UIKit.swiftinterface

I guess I need to make the failures platform-specific after all.

@jrose-apple
Copy link
Contributor Author

This still isn't 100% correct because master has fixes that I haven't built with locally, but at least it allows different platforms to be different.

@swift-ci Please test

jrose-apple
jrose-apple commented Sep 28, 2018
View reviewed changes
validation-test/ModuleInterface/verify_all_overlays.swift Outdated
macosx: ObjectiveC.swiftinterface
ios: ObjectiveC.swiftinterface
tvos: ObjectiveC.swiftinterface
watchos: ObjectiveC.swiftinterface
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one was fixed already.

jrose-apple
jrose-apple commented Sep 28, 2018
View reviewed changes
validation-test/ModuleInterface/verify_all_overlays.swift Outdated
macosx: Foundation.swiftinterface
ios: Foundation.swiftinterface
tvos: Foundation.swiftinterface
watchos: Foundation.swiftinterface
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just #19472.

jrose-apple
jrose-apple commented Sep 28, 2018
View reviewed changes
validation-test/ModuleInterface/verify_all_overlays.swift Outdated
// Needs to be built as Swift 3.
ios: CoreGraphics.swiftinterface
tvos: CoreGraphics.swiftinterface
watchos: CoreGraphics.swiftinterface
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's about to change; see #19598.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 98bd3bff907d5e1cc940022d60fe75e4e89f43a5

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 98bd3bff907d5e1cc940022d60fe75e4e89f43a5

@jrose-apple
Copy link
Contributor Author

Waiting for #19598.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7b04705bae43dd3dfb8f15b35866c2107f330b7c

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7b04705bae43dd3dfb8f15b35866c2107f330b7c

@jrose-apple jrose-apple merged commit d2fabf9 into swiftlang:master Oct 1, 2018
@jrose-apple jrose-apple deleted the reverse-airport-stop branch October 1, 2018 03:49
modelorganism pushed a commit to modelorganism/swift that referenced this pull request Oct 11, 2018
@jrose-apple @modelorganism
[test] Test compiling the overlay swiftinterfaces to binary form (swi…
a32b9e5 
…ftlang#19438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanhaskins harlanhaskins harlanhaskins approved these changes

@graydon graydon Awaiting requested review from graydon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrose-apple @swift-ci @harlanhaskins