[overlay] Build CoreGraphics overlay in Swift 4 mode #19598
Conversation
|
@swift-ci Please test macOS platform |
| // known to Swift as CGColor(red:green:blue:alpha:). Unfortunately this API | ||
| // is not available on platforms other than macOS. It would be possible to | ||
| // replicate the exact functionality of that API using | ||
| // kGColorSpaceGenericRGB, but it is marked as unavailable for Swift. The |
There was a problem hiding this comment.
I don't think we should change the behavior on macOS, though; that should continue using the generic init(red:green:blue:alpha:).
There was a problem hiding this comment.
(unless the CoreGraphics folks want it to be consistent across platforms)
There was a problem hiding this comment.
Yeah, knowing nothing about color spaces etc., I asked them for a review. Calling the old one for macOS is a good idea, and I can even do that with if #available, thanks!
There was a problem hiding this comment.
Ah, #available won't do that, since it treats platforms you don't mention as "true". You'll still want #if.
Resolves: <rdar://problem/35338851>
moiseev
force-pushed
the
core-graphics
branch
from
bbdbb16 to
8168fb8
Compare
|
@swift-ci Please test macOS platform |
|
Build failed |
|
@swift-ci Please smoke test Linux platform |
Resolves: rdar://problem/35338851