SIL: Profile the witnesMethodConformance as part of the SILFunctionType #19463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use to return a SILFunctionType with a wrong witness method protocol conformance e.g when there were base protocols. rdar://40149340
|
@swift-ci Please test and merge |
rjmccall
approved these changes
Sep 21, 2018
|
This is possibly something we should pull into 4.2, since we do rely on this information already (albeit in more constrained contexts, but I can't see why it wouldn't equally cause problems for them; maybe things just happen to always line up right because of the narrowness of how the conformance is used?). @slavapestov might have thoughts about that. |
|
4.2 branch here: #19464 |
|
@swift-ci Please test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use to return a SILFunctionType with a wrong witness method protocol
conformance e.g when there were base protocols.
rdar://40149340