Skip to content

SourceKit: use shared BlocksRuntime #19674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

SourceKit: use shared BlocksRuntime #19674

merged 1 commit into from
Oct 4, 2018

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Oct 2, 2018

Adjust the SourceKit's embedded libdispatch build to use the shared build of
BlocksRuntime now that we can generate that.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Oct 2, 2018

CC: @gottesmm @kevints

@compnerd
Copy link
Member Author

compnerd commented Oct 3, 2018

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#395

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 10b95c533251cbcfa9ad68b758dfbcdce678feb5

@compnerd
SourceKit: use shared BlocksRuntime
3469797 
Adjust the SourceKit's embedded libdispatch build to use the shared build of
BlocksRuntime now that we can generate that.
@compnerd compnerd force-pushed the shared-blocks-are-back branch from 10b95c5 to 3469797 Compare October 3, 2018 16:49
@kevints kevints mentioned this pull request Oct 3, 2018
Closed
@compnerd
Copy link
Member Author

compnerd commented Oct 3, 2018

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#396

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - 10b95c533251cbcfa9ad68b758dfbcdce678feb5

@swift-ci
Copy link
Contributor

swift-ci commented Oct 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 10b95c533251cbcfa9ad68b758dfbcdce678feb5

@compnerd
Copy link
Member Author

compnerd commented Oct 3, 2018

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#396
#19668

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 3469797

@compnerd
Copy link
Member Author

compnerd commented Oct 4, 2018

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#396

@swift-ci please test Linux platform

@compnerd
Copy link
Member Author

compnerd commented Oct 4, 2018

Lets do another run, just to verify.

@compnerd
Copy link
Member Author

compnerd commented Oct 4, 2018

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#396

@swift-ci please test

This was referenced Oct 4, 2018
Closed
Merged
Closed
@compnerd compnerd merged commit 6ab8389 into swiftlang:master Oct 4, 2018
@compnerd compnerd deleted the shared-blocks-are-back branch October 4, 2018 22:32
@Rostepher Rostepher mentioned this pull request Oct 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @swift-ci