-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Build System: CMake] Build SourceKit libdispatch with just-built clang and clang++ #19845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
Build failed |
I think that this is fine, but, it would be better to update the minimum requirements to 3.9. |
@swift-ci please clean test Linux platform |
Build failed |
… to use the just-build clang and clang++ rather than the system versions (rdar://45148295).
39b2f3e
to
a26c1b7
Compare
@swift-ci please test |
Build failed |
@swift-ci please test |
I've run a docker build locally for Ubuntu 14.04 and it builds libdispatch without the Assuming this passes testing I'm going to go ahead and merge to unblock those bots. |
Ugh actually, I just realized that this breaks cross-compilation. We can no longer build a toolchain for Windows on Linux because the just built clang is for Windows, which cannot run on Linux. |
Changed the external project build for libdispatch in tools/SourceKit to use the just-build clang and clang++ rather than the system versions. Related to #19674.
rdar://45148295