Skip to content

[Build System: CMake] Build SourceKit libdispatch with just-built clang and clang++ #19845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

Rostepher
Copy link
Contributor

Changed the external project build for libdispatch in tools/SourceKit to use the just-build clang and clang++ rather than the system versions. Related to #19674.

rdar://45148295

@Rostepher
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 39b2f3e1ea8b119d12c3a599c7137b17d31412a2

@compnerd
Copy link
Member

I think that this is fine, but, it would be better to update the minimum requirements to 3.9.

@Rostepher
Copy link
Contributor Author

@swift-ci please clean test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 39b2f3e1ea8b119d12c3a599c7137b17d31412a2

… to use the just-build clang and clang++ rather than the system versions (rdar://45148295).
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 39b2f3e1ea8b119d12c3a599c7137b17d31412a2

@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher
Copy link
Contributor Author

Rostepher commented Oct 12, 2018

I've run a docker build locally for Ubuntu 14.04 and it builds libdispatch without the #error unsupported compiler failure we've been seeing on in ci.swift.org.

Assuming this passes testing I'm going to go ahead and merge to unblock those bots.

@Rostepher Rostepher merged commit c1f17f0 into swiftlang:master Oct 12, 2018
@Rostepher Rostepher deleted the unknown-compiler branch October 12, 2018 21:53
@compnerd
Copy link
Member

Ugh actually, I just realized that this breaks cross-compilation. We can no longer build a toolchain for Windows on Linux because the just built clang is for Windows, which cannot run on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants