Skip to content

Remove the CoreImage overlay as none of the things it contains are marked public #19745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2018
Merged

Remove the CoreImage overlay as none of the things it contains are marked public #19745

merged 2 commits into from
Oct 9, 2018

Conversation

lancep
Copy link
Contributor

@lancep lancep commented Oct 5, 2018

rdar://problem/39029565

This is safe to remove as none of the additions are marked public therefore nobody is using them anyway.

@lancep
Copy link
Contributor Author

lancep commented Oct 5, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 5, 2018

Build failed
Swift Test OS X Platform
Git Sha - fa60e5e

@lancep
Copy link
Contributor Author

lancep commented Oct 5, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 5, 2018

Build failed
Swift Test OS X Platform
Git Sha - fa60e5e

@swift-ci
Copy link
Contributor

swift-ci commented Oct 5, 2018

Build failed
Swift Test Linux Platform
Git Sha - fa60e5e

@lancep lancep requested a review from moiseev October 8, 2018 16:41
moiseev
moiseev approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@moiseev moiseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lancep lancep merged commit b7ee2ba into swiftlang:master Oct 9, 2018
@lancep lancep deleted the RemoveCoreImageOverlay branch October 9, 2018 21:59
@lancep lancep mentioned this pull request Oct 10, 2018
Merged
lancep pushed a commit to lancep/swift that referenced this pull request Oct 18, 2018
Revert "Merge pull request swiftlang#19745 from lancep/RemoveCoreImag…
9d6ef32 
…eOverlay"

This reverts commit b7ee2ba, reversing
changes made to d8d0524.
shahmishal added a commit that referenced this pull request Oct 18, 2018
@shahmishal
Merge pull request #19937 from lancep/core_image_revert_cherry-pick
e033e3d 
Revert "Merge pull request #19745 from lancep/RemoveCoreImageOverlay"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moiseev moiseev moiseev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lancep @swift-ci @moiseev