Skip to content

Revert "Remove the CoreImage overlay as none of the things it contains are marked public" #19819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2018
Merged

Revert "Remove the CoreImage overlay as none of the things it contains are marked public" #19819

merged 1 commit into from
Oct 16, 2018

Conversation

lancep
Copy link
Contributor

@lancep lancep commented Oct 10, 2018

Reverts #19745

@lancep
Copy link
Contributor Author

lancep commented Oct 10, 2018

@swift-ci please smoke test and merge

@slavapestov
Copy link
Contributor

Why?

@lancep
Copy link
Contributor Author

lancep commented Oct 10, 2018

We suspect this might be the cause of some linker failures in CI. Reverting to test the theory

@lancep
Copy link
Contributor Author

lancep commented Oct 12, 2018

@swift-ci please smoke test

1 similar comment
@lancep
Copy link
Contributor Author

lancep commented Oct 15, 2018

@swift-ci please smoke test

@lancep lancep merged commit c1cabae into master Oct 16, 2018
@lancep lancep deleted the revert-19745-RemoveCoreImageOverlay branch October 16, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lancep @slavapestov