Skip to content

[Build System: build-script-impl] Cherry-pick #19834 to the 5.0 branch #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2018
Merged

[Build System: build-script-impl] Cherry-pick #19834 to the 5.0 branch #20023

merged 1 commit into from
Oct 25, 2018

Conversation

Rostepher
Copy link
Contributor

Cherry-picking #19834 to the 5.0 branch to fix the Linux PR testing bots.

@compnerd @Rostepher
build: use the exported config for libdispatch
782578b 
Pass along the configuration through the exported target for the standard
library.  Still pass the compiler by hand to allow building libdispatch against
just a build of the standard library.

(cherry picked from commit b99a0f4)
@Rostepher Rostepher requested a review from compnerd October 24, 2018 21:28
@Rostepher
Copy link
Contributor Author

@swift-ci please test

compnerd
compnerd approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a straight forward cherry-pick. If we are building on libdispatch master, then, yes, this is the right thing to do.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 782578b

@Rostepher
Copy link
Contributor Author

@swift-ci please test and merge

@shahmishal
Copy link
Member 

19:35:58 Unexpected Passing Tests (2):
19:35:58     Swift(linux-x86_64) :: Sanitizers/witness_table_lookup.swift
19:35:58     Swift(linux-x86_64) :: Sanitizers/tsan.swift

These test failure are not related to this PR, merged to unblock CI.

@shahmishal shahmishal merged commit c052770 into swiftlang:swift-5.0-branch Oct 25, 2018
@Rostepher Rostepher deleted the cherry-pick-pr-19834-to-5.0 branch January 19, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rostepher @swift-ci @shahmishal @compnerd