[Build System] Remove the use of sub-shells when running test targets #20025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject in build-script-impl. The original reasoning seems to have been to disable Ninja's output buffering which was causing the lit progress bar to behave oddly, however local (parallel) testing does not show any peculiarities now.
|
@swift-ci please test |
shahmishal
approved these changes
Oct 25, 2018
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Oct 26, 2018
…oject in build-script-impl. The original reasoning seems to have been to disable Ninja's output buffering which was causing the lit progress bar to behave oddly, however local (parallel) testing does not show any peculiarities now. (swiftlang#20025)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of sub-shells when running the test targets in
build-script-impl. We were generating a "dry-run" test command using Ninja's-noption and then executing it via/usr/env bashto avoid Ninja's output buffering when running lit in non-verbose mode. However, local testing shows the output test bar does not seem affected any longer.As a result of this change we also needed to update the
--test-pathsoption to pass the test paths through to CMake rather than appending them onto the test command. That worked before because the generated test command ended with the lit.py invocation (which seems very flimsy).rdar://43165161
rdar://33714951