Skip to content

[Build System] Remove the use of sub-shells when running test targets (5.0 branch) #20056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rostepher
Copy link
Contributor

Copy of #20025

rdar://43165161
rdar://33714951

…oject in build-script-impl. The original reasoning seems to have been to disable Ninja's output buffering which was causing the lit progress bar to behave oddly, however local (parallel) testing does not show any peculiarities now.

(cherry picked from commit 44b5a34)
@Rostepher
Copy link
Contributor Author

@swift-ci please test and merge

1 similar comment
@Rostepher
Copy link
Contributor Author

@swift-ci please test and merge

@najacque najacque merged commit c7d3017 into swiftlang:swift-5.0-branch Oct 25, 2018
@Rostepher Rostepher deleted the no-more-subshells-5.0 branch October 26, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants