Skip to content

[silgen] Scope conditionally emitted code by emitBoolDispatch. #20196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

rdar://45602910

@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 85ea987e368509415800671c25473ccbfaa1dc1e

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

Forgot to disable the test on linux.

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

macOS passed. I am going to disable the test if we don't have objc_interopt and smoke test.

@gottesmm gottesmm force-pushed the pr-287632bfd462700721e50c144278d5edb97f6b6a branch from 85ea987 to b45bea8 Compare November 1, 2018 01:53
@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

@swift-ci smoke test and merge

2 similar comments
@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

The broken test was due to the smoke test being configured not building the ARM codegenerator. I made the test conditional on that being around in #20210. So once that lands, I am going to do another macOS smoke test.

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

@swift-ci smoke test os x platform

1 similar comment
@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

@swift-ci smoke test os x platform

@gottesmm gottesmm merged commit 95e9646 into swiftlang:master Nov 1, 2018
@gottesmm gottesmm deleted the pr-287632bfd462700721e50c144278d5edb97f6b6a branch November 1, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants