Skip to content

Fix the build by ensuring that the test only runs if LLVM can compile… #20210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2018
Merged

Fix the build by ensuring that the test only runs if LLVM can compile… #20210

merged 1 commit into from
Nov 1, 2018

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Nov 1, 2018

… ARM.

@gottesmm gottesmm requested a review from rjmccall November 1, 2018 02:32
@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

@swift-ci smoke test and merge

rjmccall
rjmccall approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, I always forget that Swift is more reliant on the LLVM target being compiled in than Clang is.

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

No worries! Was a quick patch.

@gottesmm gottesmm mentioned this pull request Nov 1, 2018
Merged
@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

@swift-ci smoke test linux platform

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

@nkcsgexi @shahmishal Can I get a force merge here to unbreak the smoke tests.

@DougGregor DougGregor merged commit 47c1aa7 into swiftlang:master Nov 1, 2018
@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2018

The linux failure is different. This PR just adds a REQUIRES line to one test.

@gottesmm gottesmm deleted the pr-4e5615c56bc43f8315128b04e49229f722bfc513 branch November 1, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmccall rjmccall rjmccall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gottesmm @rjmccall @DougGregor