Skip to content

Runtime: silence some warnings #20311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Nov 4, 2018

Silence warnings about deleted defaulted constructors due to the
non-trivial constructor for the atomic type. Guard a conditionally used
function with the appropriate guard.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Nov 4, 2018

CC: @mikeash @gparker42

@compnerd
Copy link
Member Author

compnerd commented Nov 4, 2018

@swift-ci please test and merge

@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Nov 5, 2018

Build failed
Swift Test OS X Platform
Git Sha - 272d570c2a0f6f3b073d2eb907cf9ab72e011345

Silence warnings about deleted defaulted constructors due to the
non-trivial constructor for the atomic type.  Guard a conditionally used
function with the appropriate guard.
@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

@swift-ci please test and merge

@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Nov 5, 2018

Build failed
Swift Test Linux Platform
Git Sha - 272d570c2a0f6f3b073d2eb907cf9ab72e011345

@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

@swift-ci please clean test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Nov 5, 2018

Build failed
Swift Test Linux Platform
Git Sha - 1ed7874

@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

Please test with following PR:
swiftlang/swift-corelibs-foundation#1753
#20329

@swift-ci please test Linux platform

@compnerd compnerd merged commit 0e0e1a0 into swiftlang:master Nov 6, 2018
@compnerd compnerd deleted the rt-warnings branch November 6, 2018 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants