Skip to content

build: pass the framework path to the importer #20329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

build: pass the framework path to the importer #20329

merged 1 commit into from
Nov 6, 2018

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Nov 5, 2018

This is to silence the warning when building the lldb test suite.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

CC: @dcci @gottesmm

@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

@swift-ci please test and merge

jrose-apple
jrose-apple previously requested changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-F flags already get passed through to Clang, so this can't be the right fix.

@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

@jrose-apple - it definitely is getting passed to the linker as a raw -F which is a DT_FILTER. So, that causes the wrong behaviour with ELF.

@compnerd
build: adjust rpath, don't pass -F to the link
a94f317 
Pass the framework only to the importer as `-F` on ELF is used for the
`DT_FILTER`.  Adjust the `DT_RUNPATH` so that the dependent libraries are found.
@compnerd compnerd mentioned this pull request Nov 5, 2018
Merged
@jrose-apple
Copy link
Contributor

That sounds like a Clang bug, since Clang is the linker. Right?

@compnerd
Copy link
Member Author

compnerd commented Nov 5, 2018

@jrose-apple - fair enough. I don't have a problem with fixing that in clang, but, I think that we should at least do this as a temporary thing.

@compnerd compnerd mentioned this pull request Nov 5, 2018
Merged
@jrose-apple
Copy link
Contributor

That makes sense. If you end up making more changes, then, mind inserting a comment to that effect?

Thanks for the explanation!

@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 6, 2018

Build failed
Swift Test OS X Platform
Git Sha - 171c9033272f64ce03045d42389cca201e7c5098

@swift-ci
Copy link
Contributor

swift-ci commented Nov 6, 2018

Build failed
Swift Test Linux Platform
Git Sha - 171c9033272f64ce03045d42389cca201e7c5098

@jrose-apple jrose-apple dismissed their stale review November 6, 2018 02:50

We think this is a Clang issue at heart, but this gets us unblocked.

@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2018

@swift-ci please clean test macOS platform

@compnerd compnerd merged commit 14dbc9a into swiftlang:master Nov 6, 2018
@compnerd compnerd deleted the frameworks branch November 6, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @jrose-apple @swift-ci